Re: [PATCH] Revert "ata: ahci-platform: add reset control support"

From: Thierry Reding
Date: Wed Apr 18 2018 - 04:36:59 EST


On Mon, Apr 09, 2018 at 09:02:33AM +0200, Hans de Goede wrote:
> HI,
>
> On 09-04-18 03:32, Kunihiko Hayashi wrote:
> > This reverts commit f0f56716fc3e5d547fd7811eb218a30ed0695605.
> >
> > According to Thierry's view,
> > https://www.spinics.net/lists/linux-ide/msg55357.html
> > some hardware-specific drivers already use their own resets,
> > and the common reset might make a path to occur double controls of resets.
> >
> > For now, revert the commit that adds reset control support to ahci-platform,
> > and hold until the solution is confirmed not be affect all hardware-specific
> > drivers.
> >
> > Fixes: f0f56716fc3e ("ata: ahci-platform: add reset control support")
> > Reported-by: Thierry Reding <thierry.reding@xxxxxxxxx>
> > Suggested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
>
> Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Hi Tejun,

I see that you've applied this to your for-next branch. However, this is
a fix that needs to go into v4.17 because that's where the regression
was introduced. Is there any way you can promote this to a fixes branch?

Thanks,
Thierry

Attachment: signature.asc
Description: PGP signature