Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names

From: Arnaldo Carvalho de Melo
Date: Wed Apr 18 2018 - 08:53:32 EST


Em Tue, Apr 17, 2018 at 05:41:28PM -0400, Steven Rostedt escreveu:
> On Tue, 17 Apr 2018 15:13:04 -0300 Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:
> > Yeah, failing:

> > [root@jouet ~]# strace -e openat -e file perf test -F -v "mmap interface" |& grep syscalls
> > openat(AT_FDCWD, "/sys/kernel/debug/tracing/events/syscalls/sys_enter_getsid/format", O_RDONLY) = 3
> > openat(AT_FDCWD, "/sys/kernel/debug/tracing/events/syscalls/sys_enter_getppid/format", O_RDONLY) = -1 ENOENT (No such file or directory)

> It doesn't have to do with the number of parameters, not everything
> has "__x64" on it.

> Try this patch:

Trying...

> diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h
> index 09ad88572746..15582648887f 100644
> --- a/arch/x86/include/asm/ftrace.h
> +++ b/arch/x86/include/asm/ftrace.h
> @@ -31,6 +31,19 @@ static inline unsigned long ftrace_call_adjust(unsigned long addr)
> return addr;
> }
>
> +#define ARCH_HAS_SYSCALL_MATCH_SYM_NAME
> +static inline bool arch_syscall_match_sym_name(const char *sym, const char *name)
> +{
> + /*
> + * Compare the symbol name with the system call name. Skip the
> + * "__x64_sys", "__ia32_sys" or simple "sys" prefix.
> + */
> + return !strcmp(sym + 3, name + 3) ||
> + (!strncmp(sym, "__x64_", 6) && !strcmp(sym + 9, name + 3)) ||
> + (!strncmp(sym, "__ia32_", 7) && !strcmp(sym + 10, name + 3));
> +
> +}
> +
> #ifdef CONFIG_DYNAMIC_FTRACE
>
> struct dyn_arch_ftrace {