Re: [PATCH V8 1/5] crypto: Multi-buffer encryption infrastructure support

From: Herbert Xu
Date: Wed Apr 18 2018 - 23:25:37 EST


On Thu, Apr 19, 2018 at 12:54:16AM +0000, Dey, Megha wrote:
>
> Yeah I think I misunderstood. I think what you mean is to remove mcryptd.c completely and avoid the extra layer of indirection to call the underlying algorithm, instead call it directly, correct?
>
> So currently we have 3 algorithms registered for every multibuffer algorithm:
> name : __sha1-mb
> driver : mcryptd(__intel_sha1-mb)
>
> name : sha1
> driver : sha1_mb
>
> name : __sha1-mb
> driver : __intel_sha1-mb
>
> If we remove mcryptd, then we will have just the 2?

It should be down to just one, i.e., the current inner algorithm.
It's doing all the scheduling work already so I don't really see
why it needs the wrappers around it.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt