Re: [PATCH v2 2/3] ASoC: amd: dma driver changes for BT I2S instance

From: Mukunda,Vijendar
Date: Thu Apr 19 2018 - 00:34:49 EST




On Thursday 19 April 2018 05:57 AM, Daniel Kurtz wrote:
Hi Vijendar,

On Wed, Apr 18, 2018 at 5:02 AM Vijendar Mukunda <Vijendar.Mukunda@xxxxxxx>
wrote:

With in ACP, There are three I2S controllers can be
configured/enabled ( I2S SP, I2S MICSP, I2S BT).
Default enabled I2S controller instance is I2S SP.
This patch provides required changes to support I2S BT
controller Instance.

I like the direction this patch is taking, but I think it would be easier
to review if you could split it into 2 parts:
(1) the cleanup of the existing driver to use a simplified flow for
playback vs capture paths.
(2) adding the BT I2S channel.


Thanks,
-Dan


Hi Dan,

I am fine with splitting the patch into two parts.

Thanks,
Vijendar