Re: [RFC PATCH v2 2/4] acpi: apei: Split GHES handlers outside of ghes_do_proc
From: Borislav Petkov
Date: Thu Apr 19 2018 - 10:30:45 EST
On Thu, Apr 19, 2018 at 09:19:03AM -0500, Alex G. wrote:
> On the other side, you lose readability as soon as you get a few more
> handlers and the function becomes too long.
No you don't - you split it properly.
> And more importantly, you lose generality: it's not obvious that
> there's ghes_edac_report_mem_error() which too wide a context.
I don't understand what that means.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.