Re: [PATCH] sh: mm: Fix unprotected access to struct device

From: Christoph Hellwig
Date: Fri Apr 20 2018 - 04:30:52 EST


On Tue, Apr 17, 2018 at 03:54:07PM +0200, Thomas Petazzoni wrote:
>
> dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
>
> and one to switch to the WARN_ON + if(dev) model. But I don't really
> care either way, so:
>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>

Yes, these should be separate patches. And I actually hope we can
do with the NULL dev check, but that is a different sub-thread.