Re: [linux-sunxi] Re: [PATCH v2 14/16] arm: dts: sun8i: h3: enable H3 sid controller

From: Philipp Rossak
Date: Fri Apr 20 2018 - 05:36:24 EST


Hi Kyle,

I'm already working on a Version 3 of this patch series. Right now this slowed down since I'm very busy and the ToDo-List is still very long.

My plan is to send out a version during this release cycle.

If you need it right now feel free to submit patches!

Philipp

On 19.04.2018 17:19, Kyle Evans wrote:
On Thu, Apr 19, 2018 at 10:13 AM, Icenowy Zheng <icenowy@xxxxxxx> wrote:


ä 2018å4æ19æ GMT+08:00 äå11:11:22, Kyle Evans <kevans@xxxxxxxxxxx> åå:
On Mon, Jan 29, 2018 at 6:03 AM, Philipp Rossak <embed3d@xxxxxxxxx>
wrote:


On 29.01.2018 10:52, Maxime Ripard wrote:

On Mon, Jan 29, 2018 at 12:29:17AM +0100, Philipp Rossak wrote:

This patch enables the the sid controller in the H3. It can be used
for thermal calibration data.

Signed-off-by: Philipp Rossak <embed3d@xxxxxxxxx>
---
arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi
b/arch/arm/boot/dts/sun8i-h3.dtsi
index 3f83f6a27c74..9bb5cc29fec5 100644
--- a/arch/arm/boot/dts/sun8i-h3.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3.dtsi
@@ -72,6 +72,13 @@
};
};
+ soc {
+ sid: eeprom@1c14000 {
+ compatible = "allwinner,sun8i-h3-sid";
+ reg = <0x01c14000 0x400>;
+ };
+ };
+


Shouldn't you also use a nvmem-cells property to the THS node?

Maxime


Oh seems like I forgot that.
As related to the wiki [1] this should be 64 bit wide at the address
0x34. I
will add that in the next version.


[1]: http://linux-sunxi.org/SID_Register_Guide#eFUSE

Thanks,
Philipp


Hi,

Any chance this will see a v3 soon? I'm kind of interested in sid node
for h3. =)

This patch is independent and can be easily sent out
by its own.


Right- I had considered doing so, but wanted to make sure I wasn't
going to collide with this series if a v3 is imminent.