Re: [PATCH 2/3] xen netback: add fault injection facility

From: staskins
Date: Fri Apr 20 2018 - 09:02:51 EST


On 04/20/18 15:00, Juergen Gross wrote:
On 20/04/18 14:52, staskins@xxxxxxxxxx wrote:
On 04/20/18 13:25, Juergen Gross wrote:
On 20/04/18 12:47, Stanislav Kinsburskii wrote:
+ÂÂÂ for (fi = 0; fi < XENVIF_FI_MAX; fi++) {
+ÂÂÂÂÂÂÂ vfi->faults[fi] = xen_fi_dir_add(vfi->dir,
+ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ xenvif_fi_names[fi]);
How does this work? xenvif_fi_names[] is an empty array and this is the
only reference to it. Who is allocating the memory for that array?
Well, it works in the way one adds a var to enum (which is used as a key
later) and a corresponding string into the array (which is used as a
name for the fault directory in sysfs).
Then you should size the array via XENVIF_FI_MAX.

Makes sense.
Thanks!

Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B