Re: [RFC PATCH 2/2] HISI LPC: Add PNP device support

From: Andy Shevchenko
Date: Fri Apr 20 2018 - 09:28:41 EST


On Fri, 2018-04-20 at 14:09 +0100, John Garry wrote:
> On 20/04/2018 13:50, Andy Shevchenko wrote:
> > On Fri, 2018-04-20 at 18:07 +0800, John Garry wrote:

> > > + if (res->flags | IORESOURCE_IO)
> >
> > What does this mean?
>
> Here we check the resource flag for each resource for this PNP device
> -
> for IO resources we must translate the resource value from the bus
> address to the logical PIO address.

Please, re-read your code again.

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy