Re: [PATCH v4 1/2] char: sparc64: Add privileged ADI driver

[Greg KH]

On Fri, Apr 20, 2018 at 02:52:20PM -0600, Tom Hromatka wrote:
> --- /dev/null
> +++ b/drivers/char/adi.c
> @@ -0,0 +1,240 @@
> +// SPDX-License-Identifier: GPL-2.0

Good, but:

> +MODULE_LICENSE("GPL");

That's the wrong line :(

Read include/linux/module.h for the correct string to put here for a
GPL version 2 only module.

thanks,

greg k-h