[PATCH 4.16 030/196] media: rc: oops in ir_timer_keyup after device unplug

From: Greg Kroah-Hartman
Date: Sun Apr 22 2018 - 12:12:49 EST

4.16-stable review patch. If anyone has any objections, please let me know.


From: Sean Young <sean@xxxxxxxx>

commit 8d4068810d9926250dd2435719a080b889eb44c3 upstream.

If there is IR in the raw kfifo when ir_raw_event_unregister() is called,
then kthread_stop() causes ir_raw_event_thread to be scheduled, decode
some scancodes and re-arm timer_keyup. The timer_keyup then fires when
the rc device is long gone.

Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Sean Young <sean@xxxxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/media/rc/rc-main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

--- a/drivers/media/rc/rc-main.c
+++ b/drivers/media/rc/rc-main.c
@@ -1929,12 +1929,12 @@ void rc_unregister_device(struct rc_dev
if (!dev)

- del_timer_sync(&dev->timer_keyup);
- del_timer_sync(&dev->timer_repeat);
if (dev->driver_type == RC_DRIVER_IR_RAW)

+ del_timer_sync(&dev->timer_keyup);
+ del_timer_sync(&dev->timer_repeat);