RE: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS

From: Adam Thomson
Date: Sun Apr 22 2018 - 16:57:49 EST


On 22 April 2018 15:05, Greg Kroah-Hartman wrote:

> On Fri, Mar 23, 2018 at 10:12:20AM +0000, Adam Thomson wrote:
> > This commit adds code to handle requesting of PPS APDOs. Switching
> > between standard PDOs and APDOs, and re-requesting an APDO to
> > modify operating voltage/current will be triggered by an
> > external call into TCPM.
> >
> > Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx>
> > Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> > drivers/usb/typec/tcpm.c | 517
> ++++++++++++++++++++++++++++++++++++++++++++++-
> > include/linux/usb/pd.h | 4 +-
> > include/linux/usb/tcpm.h | 1 +
> > 3 files changed, 509 insertions(+), 13 deletions(-)
>
> This patch adds build warnings to the tree, so I can't take it, sorry.
> Please fix up and resend.

No problem. Sorry for that. Will take a look and resolve the warnings.