Re: [PATCH v4 1/2] char: sparc64: Add privileged ADI driver

From: Tom Hromatka
Date: Sun Apr 22 2018 - 17:53:15 EST




On 04/21/2018 03:04 AM, Greg KH wrote:
On Fri, Apr 20, 2018 at 02:52:20PM -0600, Tom Hromatka wrote:
--- /dev/null
+++ b/drivers/char/adi.c
@@ -0,0 +1,240 @@
+// SPDX-License-Identifier: GPL-2.0
Good, but:

+MODULE_LICENSE("GPL");
That's the wrong line :(

Read include/linux/module.h for the correct string to put here for a
GPL version 2 only module.


<Tom hangs his head in shame>

My sincerest apologies, Greg. I'll follow the guidance from
the aforementioned file and re-re-submit the patch tomorrow :(.

Thanks so much for your patience.

Regards,

Tom