Re: [PATCH] serial: 8250_of: Add IO space support

[John Garry]

On 23/04/2018 09:14, Greg KH wrote:
> On Thu, Apr 19, 2018 at 11:37:48PM +0800, John Garry wrote:
> > Currently the 8250_of driver only supports MEM IO type
> > accesses.
> >
> > Some development boards (Huawei D03, specifically) require
> > IO space access for 8250-compatible OF driver support, so
> > add it.
> >
> > The modification is quite simple: just set the port iotype
> > and associated flags depending on the device address
> > resource type.
> >
> > Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
>
> This no longer applies to my tree due to a patch that was sent before
> yours that conflicts in the same area.  Can you rebase it against my
> tty-testing branch and resend?

Hi Greg,

OK, I'll do that. I will also make this small improvement to this patch:

+	if ((resource.flags & IORESOURCE_TYPE_BITS) == IORESOURCE_IO) {
+		port->iotype = UPIO_PORT;

	|
	V

+	if (resource_type(&resource) == IORESOURCE_IO) {
+		port->iotype = UPIO_PORT;

All the best,
John

> thanks,
>
> greg k-h
>
> .