Re: [PATCH v5 3/6] dt-bindings: arm: Document the RZN1D-DB board

From: Simon Horman
Date: Mon Apr 23 2018 - 06:03:04 EST


On Tue, Apr 17, 2018 at 05:49:25PM +0200, Geert Uytterhoeven wrote:
> Hi Michel,
>
> On Tue, Apr 17, 2018 at 1:04 PM, Michel Pollet
> <michel.pollet@xxxxxxxxxxxxxx> wrote:
> > This documents the RZ/N1 bindings for the RZN1D-DB board.
> >
> > Signed-off-by: Michel Pollet <michel.pollet@xxxxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/arm/shmobile.txt | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt
> > index 61b486f..6efb3f1 100644
> > --- a/Documentation/devicetree/bindings/arm/shmobile.txt
> > +++ b/Documentation/devicetree/bindings/arm/shmobile.txt
> > @@ -51,7 +51,8 @@ SoCs:
> > compatible = "renesas,r8a77990"
> > - R-Car D3 (R8A77995)
> > compatible = "renesas,r8a77995"
> > -
> > + - RZ/N1D (R9A06G032)
> > + compatible = "renesas,r9a06g032", "renesas,rzn1"
>
> Why do you need a family-specific compatible value ("renesas,rzn1",
> which is a marketing name)?

Thanks Michel, Thanks Geert,

it looks like this extra compatible value should be dropped.
Its not consistent with the way other Renesas SoC families are handled
and past experience has not lead us to want family-specific compatible
values.