Re: [RFC v4 3/4] irqflags: Avoid unnecessary calls to trace_ if you can

From: Joel Fernandes
Date: Mon Apr 23 2018 - 11:49:31 EST


Hi,

On Mon, Apr 23, 2018 at 7:53 AM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Mon, 23 Apr 2018 10:31:28 -0400 (EDT)
> Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx> wrote:
[..]
>> I would be tempted to proceed carefully and introduce a new kind of SRCU
>> tracepoint rather than changing all existing ones from sched-rcu to SRCU
>> though.
>
> Agreed.
>
>>
>> So the lockdep stuff could use the SRCU tracepoint flavor, which I guess
>> would be faster than the rcu_irq_enter_*().
>
> Also agree.

I also agree about careful proceeding with separate SRCU flavor and
using that for few places first. Perhaps, if it works well once we can
benchmark it then we can slowly convert the _rcuidle API users to
this, since it seems from my testing those will benefit the most.

thanks,

- Joel