Re: [PATCH 0/9] perf tools: Assorted fixes

[Arnaldo Carvalho de Melo]

Em Mon, Apr 23, 2018 at 11:08:14AM +0200, Jiri Olsa escreveu:
> hi,
> sending assorted general fixes that queued
> up in my other branches.
> 
> Arnaldo,
> I added wait4 call in the last patch and am wondering
> if it will pass your all-distros-docker test ;-)
> If not I'll need to put some build detection code.

That wasn't a problem, but centos:5, centos:6 didn't like this:

  CC       /tmp/build/perf/util/evsel.o
cc1: warnings being treated as errors
builtin-stat.c: In function 'print_footer':
builtin-stat.c:1800: warning: declaration of 'stime' shadows a global declaration
/usr/include/time.h:297: warning: shadowed declaration is here
mv: cannot stat `/tmp/build/perf/.builtin-stat.o.tmp': No such file or directory
make[3]: *** [/tmp/build/perf/builtin-stat.o] Error 1
make[3]: *** Waiting for unfinished jobs....

debian:7 didn't like something else, unrelated to your patches:

  CC       /tmp/build/perf/util/ctype.o
builtin-buildid-cache.c: In function 'cmd_buildid_cache':
builtin-buildid-cache.c:267:2: error: 'err' may be used uninitialized in this function [-Werror=uninitialized]
builtin-buildid-cache.c:247:6: note: 'err' was declared here
  MKDIR    /tmp/build/perf/util/

I'm hunting down the patch that introduced this last one...

- Arnaldo