Re: [PATCH] USB: serial: option: adding support for ublox R410M

[Lars Melin]

On 4/26/2018 23:12, Johan Hovold wrote:
> On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote:
> > On 4/26/2018 18:39, Lars Melin wrote:
> > > On 4/26/2018 18:19, BjÃrn Mork wrote:
> > > > Anyway, Qualcomm based designs are definitely handled by both drivers.
> > > > Using qcserial only makes sense if the interface layout matches one of
> > > > the defined shared schemes, which currently are:
> > > >
> > > >  ÂÂÂÂQCSERIAL_G2K = 0,ÂÂÂ /* Gobi 2000 */
> > > >  ÂÂÂÂQCSERIAL_G1K = 1,ÂÂÂ /* Gobi 1000 */
> > > >  ÂÂÂÂQCSERIAL_SWI = 2,ÂÂÂ /* Sierra Wireless */
> > > >  ÂÂÂÂQCSERIAL_HWI = 3,ÂÂÂ /* Huawei */
> > >
> > > It seems to me that this Quectel device matches the interface layout for
> > > Gobi1K:
> > >
> > >   ÂÂÂÂÂÂÂÂ * Gobi 1K USB layout:
> > >   ÂÂÂÂÂÂÂÂ * 0: DM/DIAG (use libqcdm from ModemManager for communication)
> > >   ÂÂÂÂÂÂÂÂ * 1: serial port (doesn't respond)
> > >   ÂÂÂÂÂÂÂÂ * 2: AT-capable modem port
> > >   ÂÂÂÂÂÂÂÂ * 3: QMI/net
> > >   ÂÂÂÂÂÂÂÂ */
>
> > Ublox, not Quectel..
>
> Yeah, but qcserial appears to select a different altsetting for the DM
> port for Gobi 1000, an altsetting which this particular device does not
> have.
>
> I didn't re-read the full thread I referred to earlier, but I think in
> it, Dan mentioned Gobi 1000 device requiring firmware to be loaded too.
>
> So if it's not a G1K device, we probably shouldn't be using qcserial
> even if the interface layout happens to match.
>
> Thanks,
> Johan

Good point, I forgot about the required firmware loading for Gobi1K.
So this device should be handled by the option driver.

/Lars