Re: [PATCH] net: gemini: fix gmac_start_xmit()'s return type

From: Linus Walleij
Date: Mon Apr 30 2018 - 05:17:27 EST


On Tue, Apr 24, 2018 at 3:16 PM, Luc Van Oostenryck
<luc.vanoostenryck@xxxxxxxxx> wrote:

> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'netdev_tx_t' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks for fixing this!
Linus Walleij