Re: [PATCH 4/6] x86, memcpy_mcsafe: define copy_to_iter_mcsafe()

From: kbuild test robot
Date: Tue May 01 2018 - 18:18:39 EST


Hi Dan,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc3 next-20180501]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Dan-Williams/use-memcpy_mcsafe-for-copy_to_iter/20180502-045742
config: i386-randconfig-s1-201817 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

lib/iov_iter.c: In function 'copyout_mcsafe':
>> lib/iov_iter.c:146:7: error: implicit declaration of function 'copy_to_user_mcsafe' [-Werror=implicit-function-declaration]
n = copy_to_user_mcsafe((__force void *) to, from, n);
^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/copy_to_user_mcsafe +146 lib/iov_iter.c

141
142 static int copyout_mcsafe(void __user *to, const void *from, size_t n)
143 {
144 if (access_ok(VERIFY_WRITE, to, n)) {
145 kasan_check_read(from, n);
> 146 n = copy_to_user_mcsafe((__force void *) to, from, n);
147 }
148 return n;
149 }
150

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip