Re: [PATCH 0/2] mm: tweaks for improving use of vmap_area

From: Igor Stoppa
Date: Tue May 01 2018 - 20:05:25 EST



On 01/05/18 03:15, Andrew Morton wrote:
On Fri, 27 Apr 2018 03:42:41 +0400 Igor Stoppa <igor.stoppa@xxxxxxxxx> wrote:

These two patches were written in preparation for the creation of
protectable memory, however their use is not limited to pmalloc and can
improve the use of virtually contiguous memory.

The first provides a faster path from struct page to the vm_struct that
tracks it.

The second patch renames a single linked list field inside of vmap_area.
The list is currently used only for disposing of the data structure, once
it is not in use anymore.
Which means that it cold be used for other purposes while it's not queued
for destruction.

The patches look benign to me (feel free to add my ack),

thank you

but I'm not seeing a reason to apply them at this time?

I thought they might come useful to others playing with vmap_areas, I'll resubmit them anyway with the protected memory set.

But I was also hoping to get some more review, especially for the second, which had not received any definitive ACK/NACK, till now.

So, I'm also ok if they can be merged once the others are ACK'ed.

--
igor