Re: [PATCH] Enable clock before calling clk_get_rate() on it.

From: Stefan Potyra
Date: Wed May 02 2018 - 04:50:14 EST


Hi Evgeniy,

On Mon, Apr 30, 2018 at 06:02:57PM +0300, Evgeniy Polyakov wrote:
> Hi Stefan
>
> Nice catch, thank you!
>
> 19.04.2018, 16:02, "Stefan Potyra" <stefan.potyra@xxxxxxxxxxxxxx>:
> > According to the API, you may only call clk_get_rate() after actually
> > enabling it.
> >
> > Found by Linux Driver Verification project (linuxtesting.org).
> >
> > Fixes: a5fd9139f74c w1: add 1-wire master driver for i.MX27 / i.MX31
> > Signed-off-by: Stefan Potyra <Stefan.Potyra@xxxxxxxxxxxxxx>
>
> Acked-by: Evgeniy Polyakov <zbr@xxxxxxxxxxx>

Oops, just saw that now the clock is leaked in the error case of mdev->regs.
I'll respin the patch and fix that.

Cheers,
Stefan.

Attachment: signature.asc
Description: PGP signature