Re: [PATCH] spi-nor: Add support for Atmel Dataflash memories

From: Boris Brezillon
Date: Fri May 04 2018 - 14:39:05 EST


Hi Radu,

Sorry for the late reply.

On Wed, 28 Feb 2018 13:55:01 +0200
Radu Pirea <radu.pirea@xxxxxxxxxxxxx> wrote:

> This patch add support in spi-nor for allmost all dataflash memories
> supported by old mtd_dataflash driver.

Those devices clearly use a different instruction set, so I don't think
they fit in this framework. Can you tell us why you want to move
dataflash support to the SPI NOR framework. I think I know why, but I'd
like to get your version. My guess is that some people want to connect
dataflash chips to the Atmel QSPI controller, and it's not supported
right now because the Atmel QSPI controller implements the SPI-NOR
interface and not the generic SPI one, thus preventing anything that
is not a SPI NOR from being connected to this controller.

If I'm right, then the solution is to convert the QSPI driver to the
spi-mem interface [1] and move it to drivers/spi/.

Regards,

Boris

[1]http://patchwork.ozlabs.org/project/linux-mtd/list/?series=41174