Re: [PATCH 1/2] net: nixge: Fix error path for obtaining mac address

From: David Miller
Date: Mon May 07 2018 - 23:30:34 EST


From: Moritz Fischer <mdf@xxxxxxxxxx>
Date: Fri, 4 May 2018 10:18:33 -0700

> Fix issue where nixge_get_nvmem_address() returns a non-NULL
> return value on a failed nvmem_cell_get() that causes an invalid
> access when error value encoded in pointer is dereferenced.
>
> Furthermore ensure that buffer allocated by nvmem_cell_read()
> actually gets kfreed() if the function succeeds.
>
> Fixes commit 492caffa8a1a ("net: ethernet: nixge: Add support for
> National Instruments XGE netdev")
> Reported-by: Alex Williams <alex.williams@xxxxxx>
> Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx>

Applied.