Re: [PATCH] xen: xenbus: Fix a possible data race in xs_request_enter

[Jia-Ju Bai]

On 2018/5/8 15:02, Juergen Gross wrote:
> On 08/05/18 05:34, Jia-Ju Bai wrote:
> > The read operation to "req->type" is protected by
> > the lock on line 128, but the write operation to
> > this data on line 118 is not protected by the lock.
> > Thus, there may exist a data race for "req->type".
> >
> > To fix this data race, the write operation to "req->type"
> > should be also protected by the lock.
> No, xs_request_enter() is never called for a request already visible to
> another thread or processor. So no race exists.

Okay, thanks for your reply.


Best wishes,
Jia-Ju Bai