Re: [PATCH 03/18] printk: Convert pr_fmt from blank define to KBUILD_MODNAME

From: Sergey Senozhatsky
Date: Thu May 10 2018 - 21:52:01 EST


On (05/10/18 08:45), Joe Perches wrote:
> There are more than 1000 uses of #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> Make that the default define so these uses can be removed later via script.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

In general, the idea looks OK to me, so FWIW
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>

A quick question:

- Would "can be removed later via script" be so trivial?
What about these guys?

drivers/of/address.c:#define pr_fmt(fmt) "OF: " fmt
drivers/of/base.c:#define pr_fmt(fmt) "OF: " fmt
drivers/of/dynamic.c:#define pr_fmt(fmt) "OF: " fmt
drivers/of/fdt.c:#define pr_fmt(fmt) "OF: fdt: " fmt
drivers/of/fdt_address.c:#define pr_fmt(fmt) "OF: fdt: " fmt
drivers/of/irq.c:#define pr_fmt(fmt) "OF: " fmt
drivers/of/of_numa.c:#define pr_fmt(fmt) "OF: NUMA: " fmt
drivers/of/of_reserved_mem.c:#define pr_fmt(fmt) "OF: reserved mem: " fmt
drivers/of/overlay.c:#define pr_fmt(fmt) "OF: overlay: " fmt
drivers/of/platform.c:#define pr_fmt(fmt) "OF: " fmt
drivers/of/property.c:#define pr_fmt(fmt) "OF: " fmt
drivers/of/resolver.c:#define pr_fmt(fmt) "OF: resolver: " fmt

-ss