Re: [PATCH v2] staging: lustre: o2iblnd: Fix crash in kiblnd_handle_early_rxs()

From: Greg Kroah-Hartman
Date: Fri May 11 2018 - 05:47:26 EST

On Thu, May 10, 2018 at 11:07:01AM -0700, Doug Oucharek wrote:
> Under upstream staging commit 5a2ca43fa54f561c252c2, the list handling
> code in kiblnd_handle_early_rxs() got changed to list_for_each_safe().
> That protects against the current thread from deleting the current entry
> it is looking at. It does not protect against another thread from deleting
> the next item in the list (which the tmp variable points to). The way this
> routine holds then releases a lock opens the door to other threads doing
> just that.
> This patch reverts this commit on this routine.
> Intel-bug-id:

Please add a line like:
Fixes: 5a2ca43fa54f ("Staging: lustre: Iterate list using list_for_each_entry")

when you know this information.

Also, I'm guessing you want this backported to the stable trees? Or
does no one who actually runs lustre run a stable kernel?


greg k-h