Re: [PATCH v3] mm: Change return type to vm_fault_t

From: Souptick Joarder
Date: Sat May 12 2018 - 15:14:33 EST


>> It'd be nicer to realign the 2nd and 3rd arguments
>> on the subsequent lines.

>>
>> vm_fault_t (*fault)(const struct vm_special_mapping *sm,
>> struct vm_area_struct *vma,
>> struct vm_fault *vmf);
>>
>

> It'd be nicer if people didn't try to line up arguments at all and
> just indented by an extra two tabs when they had to break a logical
> line due to the 80-column limit.

Matthew, there are two different opinions. Which one to take ?