Re: [PATCH 1/4] amba: Export amba_bustype

From: Kim Phillips
Date: Tue May 15 2018 - 13:38:41 EST


On Tue, 15 May 2018 08:59:02 +0200
Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:

> On 8 May 2018 at 21:06, Kim Phillips <kim.phillips@xxxxxxx> wrote:
> > This patch is provided in the context of allowing the Coresight driver
> > subsystem to be loaded as modules. Coresight uses amba_bus in its call
> > to bus_find_device() in of_coresight_get_endpoint_device() when
> > searching for a configurable endpoint device. This patch allows
> > Coresight to reference amba_bustype when built as a module.
>
> Sounds like you are fixing a bug, don't your want this to go for
> stable and then also add a fixes tag?

How do you consider this a bug fix? What commit would the fixes tag
reference? The introduction of the amba bus? Not only aren't busses
required to export their bus_type, but that commit predates git.

Kim