Re: linux-next: Signed-off-by missing for commit in the pinctrl tree

From: Geert Uytterhoeven
Date: Wed May 16 2018 - 13:08:11 EST


Hi Linus,

On Wed, May 16, 2018 at 1:33 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Wed, May 16, 2018 at 1:29 PM, Geert Uytterhoeven
> <geert@xxxxxxxxxxxxxx> wrote:
>> On Wed, May 16, 2018 at 1:24 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>>> On Wed, May 16, 2018 at 9:16 AM, Geert Uytterhoeven
>>> <geert@xxxxxxxxxxxxxx> wrote:
>>>> On Tue, May 15, 2018 at 11:27 PM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>>>>> Commit
>>>>>
>>>>> f18fab4bcb4f ("pinctrl: sh-pfc: Add r8a77470 PFC support")
>>>>>
>>>>> is missing a Signed-off-by from its comitter.
>>>>
>>>> Sorry, I forgot to add it.
>>>>
>>>> Linus, as the merge of sh-pfc is your top commit, shall I fix it up
>>>> and send a new
>>>> pull request?
>>>> Please let me know how to proceed. Thanks!
>>>
>>> If it's just missing your SoB I can add it with your permission
>>> I guess? That is less trouble.
>>
>> You have my permission.
>> But I'm afraid that won't help, as then you'll become the committer with your
>> SoB missing...
>
> Bah I just sign them all off then. It's still quicker.
>
> Done!

Thanks! I'll be more careful next time.

I guess I should base my next pull request on the new commit
73dacc3403436fc2 ("pinctrl: sh-pfc: Add r8a77470 PFC support") in your
tree, instead of on my previous pull request? Else there will be some
conflicts (I checked: so far in one file only).

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds