Re: [PATCH net-next 0/3] net: Allow more drivers with COMPILE_TEST

From: David Miller
Date: Wed May 16 2018 - 13:45:06 EST


From: David Miller <davem@xxxxxxxxxxxxx>
Date: Wed, 16 May 2018 14:15:14 -0400 (EDT)

> From: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Date: Tue, 15 May 2018 16:48:22 -0700
>
>> This patch series includes more drivers to be build tested with COMPILE_TEST
>> enabled. This helps cover some of the issues I just ran into with missing
>> a driver *sigh*.
>
> Thank you for doing this.
>
> Series applied.

Actually, I have to revert.

The FEC driver cannot be built tested without the appropriate platform
specific register set defines and x86-64 for example won't provide that.

drivers/net/ethernet/freescale/fec_main.c: In function ʽfec_restartʼ:
drivers/net/ethernet/freescale/fec_main.c:959:26: error: ʽFEC_RACCʼ undeclared (first use in this function); did you mean ʽFEC_RXIC0ʼ?
val = readl(fep->hwp + FEC_RACC);
^~~~~~~~
FEC_RXIC0
drivers/net/ethernet/freescale/fec_main.c:959:26: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ethernet/freescale/fec_main.c:968:38: error: ʽFEC_FTRLʼ undeclared (first use in this function); did you mean ʽFEC_ECNTRLʼ?
writel(PKT_MAXBUF_SIZE, fep->hwp + FEC_FTRL);
^~~~~~~~
FEC_ECNTRL
...