Re: [PATCH -next] signal/mips: Report FPE_FLTUNK for undiagnosed floating point exceptions

[Eric W. Biederman]

Guenter Roeck <linux@xxxxxxxxxxxx> writes:

> Most mips builds fail with
>
> arch/mips/kernel/traps.c: In function âforce_fcr31_sigâ:
> arch/mips/kernel/traps.c:732:2: error:
> 	âsi_codeâ may be used uninitialized in this function
>
> Fix the problem by initializing si_code with FPE_FLTUNK (undiagnosed
> floating point exception).
>
> Fixes: f43a54a0d916 ("signal/mips: Use force_sig_fault where appropriate")
> Cc: linux-mips@xxxxxxxxxxxxxx
> Cc: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Applied.  Thank you.

Eric

> ---
> Feel free to merge into the patch introducing the problem.
>
>  arch/mips/kernel/traps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
> index 66ec4b0b484d..d67fa74622ee 100644
> --- a/arch/mips/kernel/traps.c
> +++ b/arch/mips/kernel/traps.c
> @@ -716,7 +716,7 @@ asmlinkage void do_ov(struct pt_regs *regs)
>  void force_fcr31_sig(unsigned long fcr31, void __user *fault_addr,
>  		     struct task_struct *tsk)
>  {
> -	int si_code;
> +	int si_code = FPE_FLTUNK;
>  
>  	if (fcr31 & FPU_CSR_INV_X)
>  		si_code = FPE_FLTINV;