Re: [PATCH 1/3] f2fs: fix to wait page writeback during revoking atomic write

From: Chao Yu
Date: Thu May 17 2018 - 20:30:19 EST


Hi Jaegeuk,

Could you recheck this patch?

On 2018/4/23 10:36, Chao Yu wrote:
> After revoking atomic write, related LBA can be reused by others, so we
> need to wait page writeback before reusing the LBA, in order to avoid
> interference between old atomic written in-flight IO and new IO.
>
> Signed-off-by: Chao Yu <yuchao0@xxxxxxxxxx>
> ---
> fs/f2fs/segment.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index cba59fc58eb6..24299f81f80d 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -231,6 +231,8 @@ static int __revoke_inmem_pages(struct inode *inode,
>
> lock_page(page);
>
> + f2fs_wait_on_page_writeback(page, DATA, true);
> +
> if (recover) {
> struct dnode_of_data dn;
> struct node_info ni;
>