Re: [PATCH v1 06/11] cpufreq: tegra20: Remove unneeded check in tegra_cpu_init

From: Viresh Kumar
Date: Thu May 17 2018 - 21:02:52 EST


On 17-05-18, 21:00, Dmitry Osipenko wrote:
> Remove checking of the CPU number for consistency as it won't ever fail
> unless there is a severe bug in the cpufreq core.
>
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
> drivers/cpufreq/tegra20-cpufreq.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/cpufreq/tegra20-cpufreq.c b/drivers/cpufreq/tegra20-cpufreq.c
> index 61f00d1cba26..147ae3e14f18 100644
> --- a/drivers/cpufreq/tegra20-cpufreq.c
> +++ b/drivers/cpufreq/tegra20-cpufreq.c
> @@ -32,8 +32,6 @@ static struct cpufreq_frequency_table freq_table[] = {
> { .frequency = CPUFREQ_TABLE_END },
> };
>
> -#define NUM_CPUS 2
> -
> static struct clk *cpu_clk;
> static struct clk *pll_x_clk;
> static struct clk *pll_p_clk;
> @@ -119,9 +117,6 @@ static int tegra_cpu_init(struct cpufreq_policy *policy)
> {
> int ret;
>
> - if (policy->cpu >= NUM_CPUS)
> - return -EINVAL;
> -
> clk_prepare_enable(cpu_clk);
>
> /* FIXME: what's the actual transition time? */

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh