Re: [PATCH ghak81 V3a] fixup! audit: collect audit task parameters

From: Ingo Molnar
Date: Fri May 18 2018 - 01:06:59 EST



* Richard Guy Briggs <rgb@xxxxxxxxxx> wrote:

> Enable fork.c compilation with audit disabled.
>
> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
> ---
> Hi Paul, this one got caught by the 0-day kbuildbot. Can you squash it
> down if you haven't merged it yet?
> ---
> kernel/fork.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 92ab849..ff82928 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1713,7 +1713,9 @@ static __latent_entropy struct task_struct *copy_process(
> p->start_time = ktime_get_ns();
> p->real_start_time = ktime_get_boot_ns();
> p->io_context = NULL;
> +#ifdef CONFIG_AUDITSYSCALL
> p->audit = NULL;
> +#endif /* CONFIG_AUDITSYSCALL */

Please, simply use:

#endif

the comment is used for (much) larger blocks, to make it clear which block ends
there if the top is not visible.

Thanks,

Ingo