Re: [PATCH net-next 1/2] net: mscc: ocelot: add bonding support

From: Andrew Lunn
Date: Fri May 18 2018 - 11:08:57 EST


On Fri, May 18, 2018 at 08:41:05AM +0200, Alexandre Belloni wrote:
> Add link aggregation hardware offload support for Ocelot.

Hi Alexandre

What i don't see here is anything checking the mode being
requested. If the user requests 'random' but the hardware only
supports 'roundrobin', you probably should not do the offload.

Andrew