Re: [PATCH net-next 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth

[Michal VokÃÄ]

On 21.5.2018 17:19, Florian Fainelli wrote:
> On 05/21/2018 06:28 AM, Michal VokÃÄ wrote:
> > By default autonegotiation is enabled to configure MAC on all ports.
> > For the CPU port autonegotiation can not be used so we need to set
> > some sensible defaults manually.
> >
> > This patch forces the default setting of the CPU port to 1000Mbps/full
> > duplex which is the chip maximum capability.
> >
> > Also correct size of the bit field used to configure link speed.
> >
> > Signed-off-by: Michal VokÃÄ <michal.vokac@xxxxxxxxx>
>
> Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
>
> Likewise, would not we want to have a:
>
> Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")
>
> tag here as well?

Good point, I will add this in v2.

Thanks,
Michal