Re: [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface"

From: Colin Ian King
Date: Tue May 22 2018 - 10:29:49 EST


On 22/05/18 16:21, Tariq Toukan wrote:
>
>
> On 22/05/2018 11:37 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>
>> Trivial fix to spelling mistake in mlx4_dbg debug message
>>
>> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>> ---
>> Â drivers/net/ethernet/mellanox/mlx4/intf.c | 2 +-
>> Â 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/intf.c
>> b/drivers/net/ethernet/mellanox/mlx4/intf.c
>> index 2edcce98ab2d..6bd4103265d2 100644
>> --- a/drivers/net/ethernet/mellanox/mlx4/intf.c
>> +++ b/drivers/net/ethernet/mellanox/mlx4/intf.c
>> @@ -172,7 +172,7 @@ int mlx4_do_bond(struct mlx4_dev *dev, bool enable)
>> ÂÂÂÂÂÂÂÂÂ list_add_tail(&dev_ctx->list, &priv->ctx_list);
>> ÂÂÂÂÂÂÂÂÂ spin_unlock_irqrestore(&priv->ctx_lock, flags);
>> Â -ÂÂÂÂÂÂÂ mlx4_dbg(dev, "Inrerface for protocol %d restarted with
>> when bonded mode is %s\n",
>> +ÂÂÂÂÂÂÂ mlx4_dbg(dev, "Interface for protocol %d restarted with when
>> bonded mode is %s\n",
>
> Thanks Colin.
> I think there's one more thing to fix here.
> It is redundant to say "with when", it was probably done by mistake.
> Let's rephrase, maybe this way?
>
> restarted with bonded mode %s

Sounds like a good idea, do you want me to send V2 of the patch with
this fix?

>
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ dev_ctx->intf->protocol, enable ?
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ "enabled" : "disabled");
>> ÂÂÂÂÂ }
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> kernel-janitors" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html