Re: [PATCH v8 2/2] leds: lm3601x: Introduce the lm3601x LED driver

[Jacek Anaszewski]

On 05/22/2018 10:34 PM, Andy Shevchenko wrote:
> On Tue, May 22, 2018 at 11:26 PM, Dan Murphy <dmurphy@xxxxxx> wrote:
> > On 05/22/2018 03:12 PM, Andy Shevchenko wrote:
> > > On Tue, May 22, 2018 at 5:24 PM, Dan Murphy <dmurphy@xxxxxx> wrote:
>
>
> > > > +static struct lm3601x_led *fled_cdev_to_led(
> > > > +                               struct led_classdev_flash *fled_cdev)
> > >
> > > Didn't notice before. This will look much better in one line.
> >
> > Gives LTL warning.
>
> I wouldn't really care about it.
> But I leave to Jacek to decide.

Please make it one line.

It is even Linus' recommendation to not strictly stick to the
80 character limit as we all have modern computers nowadays.

> After addressing the rest, FWIW,
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

--
Best regards,
Jacek Anaszewski