Re: [PATCH 01/10] mm: pagecache add lock
From: Christoph Hellwig
Date: Wed May 23 2018 - 10:29:24 EST
On Sun, May 20, 2018 at 06:45:24PM -0400, Kent Overstreet wrote:
> > Honestly I think this probably should be in the core. But IFF we move
> > it to the core the existing users of per-fs locks need to be moved
> > over first. E.g. XFS as the very first one, and at least ext4 and f2fs
> > that copied the approach, and probably more if you audit deep enough.
> I'm not going to go and redo locking in XFS and ext4 as a prerequisite to
> merging bcachefs. Sorry, but that's a bit crazy.
It isn't crazy at all. In general we expect people to do their fair
share of core work to get their pet feature in. How much is acceptable
is a difficult question and not black and white.
But if you want to grow a critical core structure you better take a stab
at converting existing users. Without that the tradeoff of growing
that core structure is simply not given.
Or to put it in words for this exact feature: unless your new field
is also used by mainstream file systems it is not going to be added.