Re: [PATCH] of: overlay: validate offset from property fixups

From: Rob Herring
Date: Wed May 23 2018 - 11:52:03 EST


On Wed, May 16, 2018 at 09:19:51PM -0700, frowand.list@xxxxxxxxx wrote:
> From: Frank Rowand <frank.rowand@xxxxxxxx>
>
> The smatch static checker marks the data in offset as untrusted,
> leading it to warn:
>
> drivers/of/resolver.c:125 update_usages_of_a_phandle_reference()
> error: buffer underflow 'prop->value' 's32min-s32max'
>
> Add check to verify that offset is within the property data.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx>
> ---
> drivers/of/resolver.c | 5 +++++
> 1 file changed, 5 insertions(+)

Applied, thanks.

Rob