Re: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events

[Kai Heng Feng]

at 10:30 PM, Mario.Limonciello@xxxxxxxx wrote:

> > -----Original Message-----
> > From: Pali RohÃr [mailto:pali.rohar@xxxxxxxxx]
> > Sent: Friday, April 20, 2018 2:29 AM
> > To: Kai-Heng Feng
> > Cc: mjg59@xxxxxxxxxxxxx; dvhart@xxxxxxxxxxxxx; andy@xxxxxxxxxxxxx;
> > Limonciello, Mario; platform-driver-x86@xxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and  
> > fn-lock
> > events
> >
> > On Friday 20 April 2018 15:26:48 Kai-Heng Feng wrote:
> > > There are two new events generated by dell-wmi, rfkill and fn-lock, from
> > > Dell Systems.
> > >
> > > When Fn-lock hotkey gets pressed to switch to function mode:
> > > [85951.591542] dell_wmi: Unknown key with type 0x0010 and code 0xe035
> > > pressed
> > > [85951.591546] dell_wmi: Unknown key with type 0x0010 and code 0x0000
> > > pressed
> > >
> > > When Fn-lock hotkey gets pressed to switch to multimedia mode:
> > > [85956.667686] dell_wmi: Unknown key with type 0x0010 and code 0xe035
> > > pressed
> > > [85956.667690] dell_wmi: Unknown key with type 0x0010 and code 0x0001
> > > pressed
> > >
> > > When radio hotkey gets pressed:
> > > [85974.430220] dell_wmi: Unknown key with type 0x0010 and code 0xe008
> > > pressed
> > >
> > > These events are for notification purpose, so we can ignore them.
> > >
> > > This patch is tested on XPS 9370.
> > >
> > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
> >
> > Reviewed-by: Pali RohÃr <pali.rohar@xxxxxxxxx>
>
> Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxxx>

Looks like this patch does not get included yet.

Kai-Heng

> > > ---
> > > v2: Reorder alphabetically.
> > >     More detailed changelog.
> > >
> > >  drivers/platform/x86/dell-wmi.c | 14 ++++++++++++++
> > >  1 file changed, 14 insertions(+)
> > >
> > > diff --git a/drivers/platform/x86/dell-wmi.c  
> > > b/drivers/platform/x86/dell-wmi.c
> > > index 8d102195a392..ba8e6725d7ac 100644
> > > --- a/drivers/platform/x86/dell-wmi.c
> > > +++ b/drivers/platform/x86/dell-wmi.c
> > > @@ -261,6 +261,12 @@ static const u16 bios_to_linux_keycode[256] = {
> > >   * override them.
> > >   */
> > >  static const struct key_entry dell_wmi_keymap_type_0010[] = {
> > > +	/* Fn-lock switched to function keys */
> > > +	{ KE_IGNORE, 0x0, { KEY_RESERVED } },
> > > +
> > > +	/* Fn-lock switched to multimedia keys */
> > > +	{ KE_IGNORE, 0x1, { KEY_RESERVED } },
> > > +
> > >  	/* Mic mute */
> > >  	{ KE_KEY, 0x150, { KEY_MICMUTE } },
> > >
> > > @@ -296,6 +302,14 @@ static const struct key_entry
> > dell_wmi_keymap_type_0010[] = {
> > > { KE_KEY,    0x851, { KEY_PROG2 } },
> > >  	{ KE_KEY,    0x852, { KEY_PROG3 } },
> > >
> > > +	/*
> > > +	 * Radio disable (notify only -- there is no model for which the
> > > +	 * WMI event is supposed to trigger an action).
> > > +	 */
> > > +	{ KE_IGNORE, 0xe008, { KEY_RFKILL } },
> > > +
> > > +	/* Fn-lock */
> > > +	{ KE_IGNORE, 0xe035, { KEY_RESERVED } },
> > >  };
> > >
> > >  /*
> >
> > --
> > Pali RohÃr
> > pali.rohar@xxxxxxxxx