Re: [PATCH 2/6] lib/rhashtable: guarantee initial hashtable allocation

From: Davidlohr Bueso
Date: Fri May 25 2018 - 07:59:21 EST


On Thu, 24 May 2018, Davidlohr Bueso wrote:
size = sizeof(*tbl) + nbuckets * sizeof(tbl->buckets[0]);
+ if (retry) {
+ gfp |= __GFP_NOFAIL;
+ tbl = kzalloc(size, gfp);
+ } /* fall-through */
+
if (gfp != GFP_KERNEL)
tbl = kzalloc(size, gfp | __GFP_NOWARN | __GFP_NORETRY);

This is wrong I'll fix in a v2, it should be _else_ if (gfp != GFP_KERNEL) ...