Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node

[Wang, Haiyue]

Hi Joel & Andrew

This patch is out of date. ;-)

New: https://patchwork.ozlabs.org/patch/893720/


On 2018-05-25 12:34, Joel Stanley wrote:
> Hello Andrew,
>
> On 16 March 2018 at 11:17, Wang, Haiyue <haiyue.wang@xxxxxxxxxxxxxxx> wrote:
> > Hi Joel and Andrew,
> >
> > Have time to review this patch ? Hope for your comments. :-)
> >
> > BR,
> > Haiyue
> >
> >
> > On 2018-03-07 13:04, Haiyue Wang wrote:
> > > The IPMI KCS device part of the LPC interface and is used for
> > > communication with the host processor.
> > >
> > > Signed-off-by: Haiyue Wang <haiyue.wang@xxxxxxxxxxxxxxx>
> Do you have time to take a look at these? The device tree doesn't make
> sense to me.
>
> Cheers,
>
> Joel
>
> > > ---
> > >    arch/arm/boot/dts/aspeed-g5.dtsi | 43
> > > +++++++++++++++++++++++++++++++++++++++-
> > >    1 file changed, 42 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi
> > > b/arch/arm/boot/dts/aspeed-g5.dtsi
> > > index 8eac57c..f443169 100644
> > > --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> > > +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> > > @@ -267,8 +267,40 @@
> > >                                  ranges = <0x0 0x1e789000 0x1000>;
> > >                                  lpc_bmc: lpc-bmc@0 {
> > > -                                       compatible =
> > > "aspeed,ast2500-lpc-bmc";
> > > +                                       compatible =
> > > "aspeed,ast2500-lpc-bmc", "simple-mfd", "syscon";
> > >                                          reg = <0x0 0x80>;
> > > +                                       reg-io-width = <4>;
> > > +
> > > +                                       #address-cells = <1>;
> > > +                                       #size-cells = <1>;
> > > +                                       ranges = <0x0 0x0 0x80>;
> > > +
> > > +                                       kcs1: kcs1@0 {
> > > +                                               compatible =
> > > "aspeed,ast2500-kcs-bmc";
> > > +                                               reg = <0x0 0x80>;
> > > +                                               interrupts = <8>;
> > > +                                               kcs_chan = <1>;
> > > +                                               kcs_addr = <0x0>;
> > > +                                               status = "disabled";
> > > +                                       };
> > > +
> > > +                                       kcs2: kcs2@0 {
> > > +                                               compatible =
> > > "aspeed,ast2500-kcs-bmc";
> > > +                                               reg = <0x0 0x80>;
> > > +                                               interrupts = <8>;
> > > +                                               kcs_chan = <2>;
> > > +                                               kcs_addr = <0x0>;
> > > +                                               status = "disabled";
> > > +                                       };
> > > +
> > > +                                       kcs3: kcs3@0 {
> > > +                                               compatible =
> > > "aspeed,ast2500-kcs-bmc";
> > > +                                               reg = <0x0 0x80>;
> > > +                                               interrupts = <8>;
> > > +                                               kcs_chan = <3>;
> > > +                                               kcs_addr = <0x0>;
> > > +                                               status = "disabled";
> > > +                                       };
> > >                                  };
> > >                                  lpc_host: lpc-host@80 {
> > > @@ -294,6 +326,15 @@
> > >                                                  status = "disabled";
> > >                                          };
> > >    +                                     kcs4: kcs4@0 {
> > > +                                               compatible =
> > > "aspeed,ast2500-kcs-bmc";
> > > +                                               reg = <0x0 0xa0>;
> > > +                                               interrupts = <8>;
> > > +                                               kcs_chan = <4>;
> > > +                                               kcs_addr = <0x0>;
> > > +                                               status = "disabled";
> > > +                                       };
> > > +
> > >                                          lhc: lhc@20 {
> > >                                                  compatible =
> > > "aspeed,ast2500-lhc";
> > >                                                  reg = <0x20 0x24 0x48
> > > 0x8>;