Re: [PATCH 8/9] regulator: bd71837: BD71837 PMIC regulator driver

[Mark Brown]

On Fri, May 25, 2018 at 10:22:53AM +0300, Matti Vaittinen wrote:
> On Thu, May 24, 2018 at 05:51:27PM +0000, Vaittinen, Matti wrote:

> > > devm_regulator_regster()

> > Makes sense. Thanks

> I was going to do 

> -       pmic = kzalloc(sizeof(struct bd71837_pmic), GFP_KERNEL);
> +       pmic = devm_kzalloc(&pdev->dev, sizeof(struct bd71837_pmic),
> +                           GFP_KERNEL);

> and

> -               rdev = regulator_register(desc, &config);
> +               rdev = devm_regulator_register(&pdev->dev, desc, &config);
> 
> but is there now a race regarding freeing the pmic structure and
> unregistering the regulator?

Why?  devm_ stuff gets unwound in the opposite order to the order in
which it was allocated.

Attachment: signature.asc
Description: PGP signature