Re: [PATCH 1/7] fs: allow per-device dax status checking for filesystems

From: Ross Zwisler
Date: Fri May 25 2018 - 11:42:54 EST


On Thu, May 24, 2018 at 10:02:18PM -0700, Darrick J. Wong wrote:
> On Thu, May 24, 2018 at 08:55:12PM -0600, Ross Zwisler wrote:
> > From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>
> >
> > Remove __bdev_dax_supported and change to bdev_dax_supported that takes a
> > bdev parameter. This enables multi-device filesystems like xfs to check
> > that a dax device can work for the particular filesystem. Once that's
> > in place, actually fix all the parts of XFS where we need to be able to
> > distinguish between datadev and rtdev.
> >
> > This patch fixes the problem where we screw up the dax support checking
> > in xfs if the datadev and rtdev have different dax capabilities.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > Signed-off-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Darr...oh, I'm not allowed to do that, am I?
>
> Would you mind (re)sending this to the xfs list so that someone else can
> review it?
>
> --D

Thanks for the review, Darrick.

I think at one point Dave said that if you touch more than 1 filesystem with a
series you should just CC linux-fsdevel and omit the individual filesystems?
I realize that this series only touches ext2 and ext4 a little, but that's
what I opted for.

Is that sufficient to get to the rest of the XFS developers, or would you like
a resend adding linux-xfs?