Re: [PATCH 1/7] core, dma-direct: add a flag 32-bit dma limits

From: Greg Kroah-Hartman
Date: Fri May 25 2018 - 12:35:57 EST


On Fri, May 25, 2018 at 06:23:07PM +0200, Christoph Hellwig wrote:
> On Fri, May 25, 2018 at 04:50:12PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, May 25, 2018 at 04:35:06PM +0200, Christoph Hellwig wrote:
> > > Various PCI bridges (VIA PCI, Xilinx PCIe) limit DMA to only 32-bits
> > > even if the device itself supports more. Add a single bit flag to
> > > struct device (to be moved into the dma extension once we around it)
> >
> > "once we around it"? I don't understand, sorry.
>
> Should be "once we get around it", which in proper grammar should
> probably be "once we get to it". Anyway, the point is that right
> now struct device is bloated with a lot of fields for dma/iommu
> purposes and we need to clean this up. It's been on my TODO list
> for a while.

Ah, makes sense, that's fine with me, I'd love to see that get cleaned
up.

thanks,

greg k-h