Re: [PATCH v2] f2fs: let fstrim issue discard commands in lower priority

From: Chao Yu
Date: Fri May 25 2018 - 20:45:42 EST


On 2018/5/26 3:49, Jaegeuk Kim wrote:
> The fstrim gathers huge number of large discard commands, and tries to issue
> without IO awareness, which results in long user-perceive IO latencies on
> READ, WRITE, and FLUSH in UFS. We've observed some of commands take several
> seconds due to long discard latency.
>
> This patch limits the maximum size to 2MB per candidate, and check IO congestion
> when issuing them to disk.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>

It looks good to me. :)

Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>

Thanks,