Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet

From: Finn Thain
Date: Mon May 28 2018 - 01:26:40 EST


On Mon, 28 May 2018, Michael Schmitz wrote:

> Hi Finn,
>
> Am 27.05.2018 um 17:49 schrieb Finn Thain:
> > On Sun, 27 May 2018, Michael Schmitz wrote:
> >
> >> That should have fixed the warning already ...
> >
> > It's still not fixed (hence my "acked-by" for Geunter's patch).
> >
>
> Odd - does link order still matter even though the
> arch_setup_dev_archdata() function from the core platform code is
> declared as a weak symbol?
>
> I'll see what I can find out on elgar ...
>

Any one of the numerous patches/rfcs/suggestions that I sent will avoid
the WARN splat.

When I said "it's still not fixed", what I meant to say was, "it's still
not fixed in mainline and no proposed fix was accepted to the best of my
knowledge".

--

> Cheers,
>
> Michael
>