Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma
From: Peter Rosin
Date: Mon May 28 2018 - 12:28:01 EST
On 2018-05-28 00:11, Peter Rosin wrote:
> On 2018-05-27 11:18, Peter Rosin wrote:
>> On 2018-05-25 16:51, Tudor Ambarus wrote:
>>> We think the best way is to keep LCD on DDR Ports 2 and 3 (8th and 9th
>>> slaves), to have maximum bandwidth and to use DMA on DDR port 1 for NAND
>>> (7th slave).
>>
>> Exactly how do I accomplish that?
>>
>> I can see how I can move the LCD between slave DDR port 2 and 3 by
>> selecting LCDC DMA master 8 or 9 (but according to the above it should
>> not matter). The big question is how I control what slave the NAND flash
>> is going to use? I find nothing in the datasheet, and the code is also
>> non-transparent enough for me to figure it out by myself without
>> throwing out this question first...
>
> I added this:
>
> diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
> index e686fe73159e..3b33c63d2ed4 100644
> --- a/drivers/mtd/nand/raw/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
> @@ -1991,6 +1991,9 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
> nc->dmac = dma_request_channel(mask, NULL, NULL);
> if (!nc->dmac)
> dev_err(nc->dev, "Failed to request DMA channel\n");
> +
> + dev_info(nc->dev, "using %s for DMA transfers\n",
> + dma_chan_name(nc->dmac));
> }
>
> /* We do not retrieve the SMC syscon when parsing old DTs. */
>
>
>
> and the output is
>
> atmel-nand-controller 10000000.ebi:nand-controller: using dma0chan5 for DMA transfers
>
> So, DMA controller 0 is in use. I still don't know if IF0, IF1 or IF2 is used
> or how to find out. I guess IF2 is not in use since that does not allow any
> DDR2 port as slave...
>
> From the datasheet, DMAC0/IF0 uses DDR2 Port 2, and DMAC0/IF1 uses DDR2 Port 1.
> But, by the looks of the register content in my other mail, it seems as if
> DMA0/IF1 can also use DDR2 Port 3.
>
> So, I think I want either
>
> A) the NAND controller to use DMAC0/IF0 (i.e. DDR2 port 1, and possibly 3) and
> the LCDC to use master 9 (i.e. DDR2 Port 2)
>
> or
>
> B) the NAND controller to use DMAC1/IF1 (i.e. DDR2 port 2) and the LCDC to use
> master 8 (i.e. DDR2 Port 3)
Crap, that was not what I meant to express. Sorry for the confusion. This is
better.
So, I think I want either
A) the NAND controller to use master 1 DMAC0/IF0 (i.e. slave 8 DDR2 port 2) and
the LCDC to use master 9 (i.e. slave 9 DDR2 Port 3)
or
B) the NAND controller to use master 2 DMAC0/IF1 (i.e. slave 7 DDR2 port 1, and
possibly slave 9 DDR2 port 3 (if my previous findings are relevant) and the
LCDC to use master 8 (i.e. slave 8 DDR2 Port 2)
> But, again, how do I limit DMAC0 to either of IF0 or IF1 for NAND accesses?
So, I added a horrid patch (attached), which mainly adds printk lines, but
additionally does one more thing in atc_prep_dma_memcpy. It changes the DSCR_IF
field (from 0) to 1 for DMA-memcpy for dma0chan5 (i.e. the NAND). At least I
think it does that?
Running with that patch gets me this:
# dmesg | grep -i dma
at_hdmac ffffe600.dma-controller: Atmel AHB DMA Controller ( cpy set slave ), 8 channels
at_hdmac ffffe800.dma-controller: Atmel AHB DMA Controller ( cpy set slave ), 8 channels
dma dma0chan0: xlate 0 2
dma dma0chan1: xlate 0 2
at91_i2c f0014000.i2c: using dma0chan0 (tx) and dma0chan1 (rx) for DMA transfers
dma dma1chan0: xlate 0 2
dma dma1chan1: xlate 0 2
at91_i2c f801c000.i2c: using dma1chan0 (tx) and dma1chan1 (rx) for DMA transfers
dma dma0chan2: xlate 0 2
dma dma0chan3: xlate 0 2
dma dma0chan4: xlate 0 2
atmel_mci f0000000.mmc: using dma0chan4 for DMA transfers
dma dma1chan2: xlate 0 2
dma dma1chan3: xlate 0 2
atmel_aes f8038000.aes: Atmel AES - Using dma1chan2, dma1chan3 for DMA transfers
dma dma1chan4: xlate 0 2
atmel_sha f8034000.sha: using dma1chan4 for DMA transfers
dma dma1chan5: xlate 0 2
dma dma1chan6: xlate 0 2
atmel_tdes f803c000.tdes: using dma1chan5, dma1chan6 for DMA transfers
atmel-nand-controller 10000000.ebi:nand-controller: using dma0chan5 for DMA transfers
dma dma0chan5: memcpy: 0
dma dma0chan5: DSCR_IF: 1
dma dma0chan5: memcpy: 1
So, output is as expected and I believe that the patch makes the NAND DMA
accesses use master 2 DMAC0/IF1 and are thus forced to use slave 7 DDR2 Port 1
(and possibly 9). The LCDC is using slave 8 DDR2 Port 2. So there should be no
slave conflict?
But the on-screen crap remains during NAND accesses.
But pressing on.
I then changed the priorities for all accesses to 0 in the PRxSy registers, except
the ones for masters 8/9 LCDC (slaves 8/9) which I left at priority 3.
But the on-screen crap remains during NAND accesses.
My guess is that the NAND DMA is doing too long bursts and that the LCDC therefore
has to wait too long and simply fails to keep the pipeline from running short?
So I tried to reduce the maximum SLOT_CYCLE for slaves 7 and 9 in the SCFGx
registers. No noticeable effect either.
I then tried to split bursts from master 2 (DMAC0/IF1) with small values in the
MCFG2 register. No effect.
I'm getting nowhere.
Cheers,
Peter
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 75f38d19fcbe..6cb58197bd29 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -243,6 +243,18 @@ static void atc_dostart(struct at_dma_chan *atchan, struct at_desc *first)
vdbg_dump_regs(atchan);
+ if (atchan->chan_common.chan_id == 5 &&
+ atchan->chan_common.device->dev_id == 0)
+ {
+ static u32 last_if = 4;
+ u32 this_if = first->txd.phys & 3;
+ if (this_if != last_if) {
+ dev_info(chan2dev(&atchan->chan_common),
+ "DSCR_IF: %u\n", this_if);
+ last_if = this_if;
+ }
+ }
+
channel_writel(atchan, SADDR, 0);
channel_writel(atchan, DADDR, 0);
channel_writel(atchan, CTRLA, 0);
@@ -854,6 +866,19 @@ atc_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,
desc->lli.ctrlb = ctrlb;
desc->txd.cookie = 0;
+ if (chan->chan_id == 5 &&
+ chan->device->dev_id == 0)
+ {
+ static u32 last_if = 4;
+ u32 this_if = desc->txd.phys & 3;
+ if (this_if != last_if) {
+ dev_info(chan2dev(chan),
+ "memcpy: %u\n", this_if);
+ last_if = this_if;
+ }
+ desc->txd.phys = (desc->txd.phys & ~3) | 1;
+ }
+
desc->len = xfer_count << src_width;
atc_desc_chain(&first, &prev, desc);
@@ -1107,6 +1132,8 @@ atc_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
| ATC_SRC_ADDR_MODE_INCR
| ATC_FC_MEM2PER
| ATC_SIF(atchan->mem_if) | ATC_DIF(atchan->per_if);
+ dev_info(chan2dev(chan), "slave_sg: mem2dev %d %d\n",
+ atchan->mem_if, atchan->per_if);
reg = sconfig->dst_addr;
for_each_sg(sgl, sg, sg_len, i) {
struct at_desc *desc;
@@ -1147,6 +1174,8 @@ atc_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
| ATC_SRC_ADDR_MODE_FIXED
| ATC_FC_PER2MEM
| ATC_SIF(atchan->per_if) | ATC_DIF(atchan->mem_if);
+ dev_info(chan2dev(chan), "slave_sg: dev2mem %d %d\n",
+ atchan->mem_if, atchan->per_if);
reg = sconfig->src_addr;
for_each_sg(sgl, sg, sg_len, i) {
@@ -1255,6 +1284,8 @@ atc_dma_cyclic_fill_desc(struct dma_chan *chan, struct at_desc *desc,
| ATC_FC_MEM2PER
| ATC_SIF(atchan->mem_if)
| ATC_DIF(atchan->per_if);
+ dev_info(chan2dev(chan), "fill_desc: mem2dev %d %d\n",
+ atchan->mem_if, atchan->per_if);
desc->len = period_len;
break;
@@ -1267,6 +1298,8 @@ atc_dma_cyclic_fill_desc(struct dma_chan *chan, struct at_desc *desc,
| ATC_FC_PER2MEM
| ATC_SIF(atchan->per_if)
| ATC_DIF(atchan->mem_if);
+ dev_info(chan2dev(chan), "fill_desc: dev2mem %d %d\n",
+ atchan->mem_if, atchan->per_if);
desc->len = period_len;
break;
@@ -1344,6 +1377,18 @@ atc_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf_addr, size_t buf_len,
atc_desc_chain(&first, &prev, desc);
}
+ if (chan->chan_id == 5 &&
+ chan->device->dev_id == 0)
+ {
+ static u32 last_if = 4;
+ u32 this_if = first->txd.phys & 3;
+ if (this_if != last_if) {
+ dev_info(chan2dev(chan),
+ "cyclic: %u\n", this_if);
+ last_if = this_if;
+ }
+ }
+
/* lets make a cyclic list */
prev->lli.dscr = first->txd.phys;
@@ -1712,6 +1757,8 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec,
atchan = to_at_dma_chan(chan);
atchan->per_if = dma_spec->args[0] & 0xff;
atchan->mem_if = (dma_spec->args[0] >> 16) & 0xff;
+ dev_info(chan2dev(chan), "xlate %d %d\n",
+ atchan->mem_if, atchan->per_if);
return chan;
}
@@ -2099,6 +2146,18 @@ static void atc_resume_cyclic(struct at_dma_chan *atchan)
{
struct at_dma *atdma = to_at_dma(atchan->chan_common.device);
+ if (atchan->chan_common.chan_id == 5 &&
+ atchan->chan_common.device->dev_id == 0)
+ {
+ static u32 last_if = 4;
+ u32 this_if = atchan->save_dscr;
+ if (this_if != last_if) {
+ dev_info(chan2dev(&atchan->chan_common),
+ "resume_cyclic: %u\n", this_if);
+ last_if = this_if;
+ }
+ }
+
/* restore channel status for cyclic descriptors list:
* next descriptor in the cyclic list at the time of suspend */
channel_writel(atchan, SADDR, 0);
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
index e686fe73159e..3b33c63d2ed4 100644
--- a/drivers/mtd/nand/raw/atmel/nand-controller.c
+++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -1991,6 +1991,9 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc,
nc->dmac = dma_request_channel(mask, NULL, NULL);
if (!nc->dmac)
dev_err(nc->dev, "Failed to request DMA channel\n");
+
+ dev_info(nc->dev, "using %s for DMA transfers\n",
+ dma_chan_name(nc->dmac));
}
/* We do not retrieve the SMC syscon when parsing old DTs. */